fix/limiter-accuracy-and-deps #1

Merged

tbdsux merged 10 commits from fix/limiter-accuracy-and-deps into main

2026-11-02 04:16:07 +00:00

tbdsux commented

2026-11-02 04:15:43 +00:00

Owner

No description provided.

tbdsux added 10 commits

2026-11-02 04:15:43 +00:00

chore(deps): upgrade dependencies 627ba5423c

Replace httpx with httpx2, which Starlette's test client now expects.

style: apply ruff 0.17 lint rules 92bc54e394

fix(identifier)!: stop trusting X-Forwarded-For 5cecba6df8

Clients can forge the header to get a fresh counter on every request. Apps
behind a proxy must now have the server resolve the client address, for
example with uvicorn --forwarded-allow-ips.

fix(headers)!: report correct rate limit times 41eca58497

Retry-After was a millisecond timestamp and is now a delay in seconds. Reset
times compared bucket timestamps to a monotonic clock, which was wrong for
wall-clock backends, so they now use the bucket's own clock. A 429 reports the
rate that failed. Also removes the unused exception handler from RateLimiter.

fix(callback): reject requests when a callback returns 9bba4065c3

A callback that returned instead of raising let the request through in the
dependency and caused a 500 in the middleware. Both now send the default 429.

fix(factory)!: keep sanitized bucket names unique and bounded 5735f1b552

Different identifiers could collapse to one name and share a counter, and long
paths produced unbounded names. Most names change, so existing SQLite and Redis
counters start fresh.

fix(factory): support async bucket factories and clocks b4b2b15448

Async Redis clients returned 500s because the factory stored the unawaited
bucket, and async clocks crashed once a bucket was cached.

fix(factory): evict idle buckets f1e4e41c08

Every unique identifier kept a bucket forever, so clients could grow memory by
requesting random paths. Empty buckets hold no state and are now dropped about
once a minute. Async buckets are not evicted yet.

fix(buckets): stop per-identifier processes and files, forward options

CI / ci (push) Has been cancelled

Details

9dc8bd03f1

The multiprocess bucket started one Manager process per identifier and now
shares one. SQLite with no db_path now uses one temp file. Redis and Postgres
options now apply to every identifier, and Postgres no longer drops them.
The simple examples now use the plain in-memory bucket.

ci: run on ubuntu-latest with Forgejo checkout action

CI / ci (push) Successful in 36s

Details

CI / ci (pull_request) Successful in 14s

Details

098599a7d4

codeberg-tiny is a Codeberg runner label and the repo now lives on a self-hosted Forgejo. Use the short checkout reference at its latest major version, v7.

tbdsux merged commit 9374ba4da6 into main

2026-11-02 04:16:07 +00:00

tbdsux referenced this pull request from a commit

2026-11-02 04:16:09 +00:00

Merge pull request 'fix/limiter-accuracy-and-deps' (#1) from fix/limiter-accuracy-and-deps into main

tbdsux deleted branch fix/limiter-accuracy-and-deps

2026-11-02 04:16:11 +00:00